Skip to content

[UI] Displaying elements based on user permissions in Twig #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 4, 2025
Merged

[UI] Displaying elements based on user permissions in Twig #212

merged 13 commits into from
Mar 4, 2025

Conversation

andersonjeccel
Copy link
Contributor

This PR shows how to display things conditionally in Twig based on permissions for less-technical people.

@escopecz I'd like your review

@andersonjeccel andersonjeccel force-pushed the ui-Displaying-Elements-Based-on-User-Permissions branch from 5694a84 to c4cb0ae Compare September 9, 2024 20:46
escopecz
escopecz approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct from the technical review point of view 👍

RCheesley
RCheesley requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Vale fixes here - please also can you fix the heading nesting as it's using the wrong syntax.

For reference:

H1 ###
H2 ***
H3 ===
H4 ---
H5 ~~~

@RCheesley RCheesley added documentation Improvements or additions to documentation pending-feedback hacktoberfest-accepted labels Oct 24, 2024
andersonjeccel and others added 11 commits October 24, 2024 10:04
@andersonjeccel @RCheesley
Update docs/design/displaying_elements_based_on_user_permissions.rst
7eaa5c4 
Co-authored-by: Ruth Cheesley <[email protected]>
@andersonjeccel @RCheesley
Update docs/design/displaying_elements_based_on_user_permissions.rst
28272a6 
Co-authored-by: Ruth Cheesley <[email protected]>
@andersonjeccel @RCheesley
Update docs/design/displaying_elements_based_on_user_permissions.rst
4379dd8 
Co-authored-by: Ruth Cheesley <[email protected]>
@andersonjeccel @RCheesley
Update docs/design/displaying_elements_based_on_user_permissions.rst
215162c 
Co-authored-by: Ruth Cheesley <[email protected]>
@andersonjeccel @RCheesley
Update docs/design/displaying_elements_based_on_user_permissions.rst
6da0493 
Co-authored-by: Ruth Cheesley <[email protected]>
@andersonjeccel @RCheesley
Update docs/design/displaying_elements_based_on_user_permissions.rst
5c1b505 
Co-authored-by: Ruth Cheesley <[email protected]>
@andersonjeccel @RCheesley
Update docs/design/displaying_elements_based_on_user_permissions.rst
e2f1a69 
Co-authored-by: Ruth Cheesley <[email protected]>
@andersonjeccel @RCheesley
Apply suggestions from code review
93f828f 
Co-authored-by: Ruth Cheesley <[email protected]>
@RCheesley
Heading fixes, vale fixes.
8a56ac6
@RCheesley
Merge branch '5.x' into ui-Displaying-Elements-Based-on-User-Permissions
efe3c43
@RCheesley
Add missing index.rst entry in TOCTree
c634df6
@RCheesley RCheesley merged commit 40ca074 into mautic:5.x Mar 4, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCheesley RCheesley RCheesley requested changes

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation hacktoberfest-accepted pending-feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersonjeccel @escopecz @RCheesley